Update hint texts of all entries

The design team discussed the ellipses at the end of the hint text of
our entries and, even though they are present in most mockups, it turned
out they don't like them, so remove them.

It also turned out they don't like the prefixes like "Enter" before it,
so remove those, too.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/977

diff --git a/js/gdm/loginDialog.js b/js/gdm/loginDialog.js
index c7bb7b06e8066edd1ade9759a7510a9515d58805..92cb256ef6bf09ad89bb560deb129a9cff5e1e1a 100644 (file)
--- a/js/gdm/loginDialog.js
+++ b/js/gdm/loginDialog.js
@@ -914,7 +914,7 @@ var LoginDialog = GObject.registerClass({
 
     _askForUsernameAndBeginVerification() {
         this._authPrompt.setUser(null);
-        this._authPrompt.setQuestion(_('Username…'));
+        this._authPrompt.setQuestion(_('Username'));
 
         this._showRealmLoginHint(this._realmManager.loginFormat);
 

diff --git a/js/ui/components/polkitAgent.js b/js/ui/components/polkitAgent.js
index 4228cac4b8e921b1e7ab824e211e31ba04935f56..7fdfd1006f2032bd2e6156ec3623af57c9d534f2 100644 (file)
--- a/js/ui/components/polkitAgent.js
+++ b/js/ui/components/polkitAgent.js
@@ -271,12 +271,12 @@ var AuthenticationDialog = GObject.registerClass({
         }
 
         // Hack: The request string comes directly from PAM, if it's "Password:"
-        // we replace it with our own, if it's something else we replace the
-        // last colon and any trailing spaces with a "…".
+        // we replace it with our own to allow localization, if it's something
+        // else we remove the last colon and any trailing or leading spaces.
         if (request === 'Password:' || request === 'Password: ')
-            this._passwordEntry.hint_text = _('Enter Password…');
+            this._passwordEntry.hint_text = _('Password');
         else
-            this._passwordEntry.hint_text = request.replace(/: *$/, '…');
+            this._passwordEntry.hint_text = request.replace(/: *$/, '').trim();
 
         this._passwordEntry.password_visible = echoOn;
 

diff --git a/js/ui/overview.js b/js/ui/overview.js
index 10703e300cbbedddf799d73426c316313d9508a0..62a3c0917a9247a854da1d4c4879aeab339d68a9 100644 (file)
--- a/js/ui/overview.js
+++ b/js/ui/overview.js
@@ -104,7 +104,7 @@ class OverviewActor extends St.BoxLayout {
                in the search entry when no search is
                active; it should not exceed ~30
                characters. */
-            hint_text: _("Type to search…"),
+            hint_text: _('Type to search'),
             track_hover: true,
             can_focus: true,
         });

diff --git a/js/ui/shellMountOperation.js b/js/ui/shellMountOperation.js
index c6e6def8cf0e6d8a2e63eef105f0e0db1571121f..702f2c2b61dc83d0e9d5dadd2237a2526c7d8843 100644 (file)
--- a/js/ui/shellMountOperation.js
+++ b/js/ui/shellMountOperation.js
@@ -303,7 +303,7 @@ var ShellMountPasswordDialog = GObject.registerClass({
 
             this._pimEntry = new St.PasswordEntry({
                 style_class: 'prompt-dialog-password-entry',
-                hint_text: _('Enter PIM Number…'),
+                hint_text: _('PIM Number'),
                 can_focus: true,
                 x_expand: true,
             });
@@ -323,7 +323,7 @@ var ShellMountPasswordDialog = GObject.registerClass({
 
         this._passwordEntry = new St.PasswordEntry({
             style_class: 'prompt-dialog-password-entry',
-            hint_text: _('Enter Password…'),
+            hint_text: _('Password'),
             can_focus: true,
             x_expand: true,
         });